-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark tool runfiles as such in expanded execution log #23702
Conversation
@tjgq I have only modified the test so far. I'm not entirely sure whether and how to fix this for the expanded format. Is there a cheap way to get all the artifacts that a runfiles middleman contains, without flattening additional nested sets? |
The expanded execution log did not mark any runfiles as tools, but the (local and remote) worker implementations explicitly do check whether a runfiles middleman is a tool. Also uses a previously unused test parameter in `testRunfileSymlinkFileWithDirectoryContents`.
20a32e9
to
5b2421a
Compare
Nevermind, I think I found a way to do it without much overhead. |
@bazel-io fork 7.4.0 |
Cherry-picks the following changes: * Optimize representation of runfiles in compact execution log (bazelbuild#23321) * Keep runfiles tree IDs in memory for multiple test attempts (bazelbuild#23703) * Fix naming inconsistency in `spawn.proto` (bazelbuild#23706) * Mark tool runfiles as such in expanded execution log (bazelbuild#23702) The cherry-picks required introducing a `Map<Artifact, RunfilesTree>` shim to `RunfilesSupplier` that matches the Bazel 8 way of obtaining a `RunfilesTree` from a runfiles middleman via `InputMetadataProvider`. Closes bazelbuild#23683 Closes bazelbuild#23710 Closes bazelbuild#23711 Closes bazelbuild#23734
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
The expanded execution log did not mark any runfiles as tools, but the (local and remote) worker implementations explicitly do check whether a runfiles middleman is a tool.
Also adds a missing usage of a test parameter in
testRunfileSymlinkFileWithDirectoryContents
.