Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rules_python for Bazel #23735

Closed

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Sep 24, 2024

But pinning protobuf to older version

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 24, 2024
@comius
Copy link
Contributor

comius commented Sep 24, 2024

LGTM, but can I have MODULE.tools as well? That's were autoloaded rules_python are coming from.

@Wyverald
Copy link
Member

I haven't tried, but upgrading rules_python in bazel_tools could be more problematic because we can't pin a module version in a non-root module (IOW, no single_version_override).

@meteorcloudy
Copy link
Member Author

Fortunately, the new rules_python version only requires protobuf 24.4, which doesn't have the problem. #23749 is working and I'll close this one.

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants