Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4.0] Use millisecond precision when setting the last modified time on Unix. #23740

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented Sep 24, 2024

Currently, we truncate to second precision. Instead, make use of utimensat(2), which can accommodate up to nanosecond precision, is part of POSIX, and is widely available (Linux, Darwin, OpenBSD, FreeBSD and NetBSD).

PiperOrigin-RevId: 678185275
Change-Id: I307dbc75c8f594e6d70b43ee0bde2226b3015611

… on Unix.

Currently, we truncate to second precision. Instead, make use of utimensat(2), which can accommodate up to nanosecond precision, is part of POSIX, and is widely available (Linux, Darwin, OpenBSD, FreeBSD and NetBSD).

PiperOrigin-RevId: 678185275
Change-Id: I307dbc75c8f594e6d70b43ee0bde2226b3015611
@tjgq tjgq requested a review from a team as a code owner September 24, 2024 19:12
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 24, 2024
@Wyverald Wyverald added this pull request to the merge queue Sep 24, 2024
Merged via the queue into bazelbuild:release-7.4.0 with commit 6b95332 Sep 24, 2024
51 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 24, 2024
@iancha1992 iancha1992 added this to the 7.4.0 release blockers milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants