Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.4.0] external dependency doc updates #23741

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Conversation

Wyverald
Copy link
Member

original commits:

Wyverald and others added 6 commits September 24, 2024 15:11
- Most references to WORKSPACE are changed to MODULE.bazel & friends
- Added information about the order in which Bazel looks for toolchains in MODULE.bazel + WORKSPACE
- More consistent terminology (eg. 'workspace' -> 'repo' when appropriate)
- More info about how `mirrors` in `bazel_registry.json` works

PiperOrigin-RevId: 595179646
Change-Id: I37aff58a2723aa830efeafb589fcf770e07b3711
`http_archive` is not local - it does not re-download external repos on bazel server restart. Having `local=True` in the example is somewhat confusing.

Looks it was leftover after some older change:
13ecdf5#diff-1f760cde585b814b5608e64ade35cfa8f6fc0b1082316adc2f1bac412169a10eL41

Closes #22084.

PiperOrigin-RevId: 627954043
Change-Id: Ie25f5f0141401e194be99c9d02ec81c0ab619484
Fixes:
```
syntax error at '"sha256"': expected }
```

Closes #23027.

PiperOrigin-RevId: 653606521
Change-Id: If52071612ab09bf5c0d77fbde228f9e664569d75
The remarks about files being watched only if they're labels are no longer accurate.

Repo rule restarts are gone by default (`--experimental_worker_for_repo_fetching` defaults to `auto`), so the section doesn't really apply anymore.

Fixes #22494

PiperOrigin-RevId: 668317824
Change-Id: Iba380b944cce2b5c8e7bd07606b89035ab401e72
@Wyverald Wyverald requested a review from a team as a code owner September 24, 2024 19:20
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Documentation Documentation improvements that cannot be directly linked to other team labels labels Sep 24, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Sep 24, 2024
@iancha1992 iancha1992 removed this pull request from the merge queue due to a manual request Sep 24, 2024
@Wyverald Wyverald added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@Wyverald Wyverald added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@iancha1992 iancha1992 added this pull request to the merge queue Sep 25, 2024
Merged via the queue into release-7.4.0 with commit e253020 Sep 25, 2024
53 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 25, 2024
@Wyverald Wyverald deleted the wyv-740-c04a561 branch September 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants