-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.4.0] external dependency doc updates #23741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Most references to WORKSPACE are changed to MODULE.bazel & friends - Added information about the order in which Bazel looks for toolchains in MODULE.bazel + WORKSPACE - More consistent terminology (eg. 'workspace' -> 'repo' when appropriate) - More info about how `mirrors` in `bazel_registry.json` works PiperOrigin-RevId: 595179646 Change-Id: I37aff58a2723aa830efeafb589fcf770e07b3711
`http_archive` is not local - it does not re-download external repos on bazel server restart. Having `local=True` in the example is somewhat confusing. Looks it was leftover after some older change: 13ecdf5#diff-1f760cde585b814b5608e64ade35cfa8f6fc0b1082316adc2f1bac412169a10eL41 Closes #22084. PiperOrigin-RevId: 627954043 Change-Id: Ie25f5f0141401e194be99c9d02ec81c0ab619484
Fixes: ``` syntax error at '"sha256"': expected } ``` Closes #23027. PiperOrigin-RevId: 653606521 Change-Id: If52071612ab09bf5c0d77fbde228f9e664569d75
The remarks about files being watched only if they're labels are no longer accurate. Repo rule restarts are gone by default (`--experimental_worker_for_repo_fetching` defaults to `auto`), so the section doesn't really apply anymore. Fixes #22494 PiperOrigin-RevId: 668317824 Change-Id: Iba380b944cce2b5c8e7bd07606b89035ab401e72
cherry-pick of commit c04a561
github-actions
bot
added
awaiting-review
PR is awaiting review from an assigned reviewer
team-Documentation
Documentation improvements that cannot be directly linked to other team labels
labels
Sep 24, 2024
iancha1992
approved these changes
Sep 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2024
github-actions
bot
removed
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
team-Documentation
Documentation improvements that cannot be directly linked to other team labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original commits: