-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade everything! #23767
Upgrade everything! #23767
Conversation
6679c4c
to
7038438
Compare
Currently stuck on making HEAD Bazel build itself. At the source checkout state of this PR, I can run
Using Bazel 7.3.1 and the just-built Bazel to cquery the provider list, the difference is evident: $ USE_BAZEL_VERSION=7.3.1 bazelisk cquery "'@@protobuf+//src/google/protobuf:duration_proto'" --output=starlark --starlark:expr="providers(target)"
INFO: Analyzed target @@protobuf+//src/google/protobuf:duration_proto (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
{"LicenseInfo": <instance of provider LicenseInfo>, "@@_builtins//:common/proto/proto_info.bzl%ProtoInfo": struct( [...]
$ ~/elsewhere/bazel cquery "'@@protobuf+//src/google/protobuf:duration_proto'" --output=starlark --starlark:expr="providers(target)"
INFO: Analyzed target @@protobuf+//src/google/protobuf:duration_proto (128 packages loaded, 2060 targets configured).
INFO: Found 1 target...
{"LicenseInfo": <instance of provider LicenseInfo>, "@@protobuf+//bazel/private:proto_info.bzl%ProtoInfo": struct( [...] it looks like on HEAD Bazel, the proto_library targets export the ProtoInfo from protobuf, but the rule itself for some reason expects deps to have the ProtoInfo from builtins. |
bca80c3
to
0c8f971
Compare
The issue above has been addressed by 3cb5bea. This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!!
@Wyverald Can you merge this one since there are many BUILD file changes. We'll also need a separate PR to delete googleapis from third_party. |
Partial commit for third_party/*, see #23767. Change-Id: I5696cc64436dcec9ea87f72696abad50e4ba3619 Signed-off-by: Xudong Yang <wyv@google.com>
What started out as an attempt to upgrade gRPC has snowballed into this monster...
grpc-java
grpc-java
actually specifies Maven overrides, causing rules_jvm_external's references toio.grpc.*
andcom.google.protobuf.*
to alias to actual Bazel build targets in@grpc-java
and@protobuf
. So this effectively means we're no longer using the gRPC jars from Mavenrules_jvm_external
had to be updated to include thealias
targets in theBUILD.vendor
file.Fixes #22719