Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rules_java_builtin in WORKSPACE prefix #23773

Closed
wants to merge 6 commits into from
Closed

Remove rules_java_builtin in WORKSPACE prefix #23773

wants to merge 6 commits into from

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Sep 26, 2024 •
edited
Loading

Benefits:

  • Less hack in WORKSPACE
  • Smaller Bazel binary size since we no longer embed rules_java

Costs:

  • WORKSPACE users have to always fetch rules_java.
  • WORKSPACE users have to ensure a compatible rules_java is defined.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 26, 2024
@iancha1992 iancha1992 added the team-Rules-Java Issues for Java rules label Sep 26, 2024
@meteorcloudy meteorcloudy marked this pull request as draft September 27, 2024 10:01
@meteorcloudy meteorcloudy changed the title Remove WORKSPACE injections for rules_java Remove rules_java_builtin in WORKSPACE prefix Sep 27, 2024
@meteorcloudy meteorcloudy marked this pull request as ready for review September 27, 2024 11:03
@meteorcloudy
Copy link
Member Author

I'm not removing java aliases from bazel_tools in this PR, I'll have to check how intrusive that is.

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvadehra hvadehra hvadehra approved these changes

@comius comius Awaiting requested review from comius

Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meteorcloudy @hvadehra @iancha1992