Weakly cache runfiles mappings of tools #23774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks showed that this can reduce eden space garbage by 1-4%.
fmeum
requested review from
aranguyen and
justinhorvitz
and removed request for
a team and
aranguyen
github-actions
bot
added
team-Configurability
|
@justinhorvitz I added some comments for future readers of the OSS code base without access to buganizer. Feel free to change them as you see fit. |
|
@bazel-io fork 7.4.0 |
justinhorvitz
approved these changes
Sep 26, 2024
|
@justinhorvitz The failure of |
|
Spoke with the author of this test. I'm going to import this PR and disable the test for now and we'll plan to add better handling for |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks showed that this can reduce eden space garbage by 1-4%.