[7.4.0] Make launcher_maker cross-platform
#23781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`//tools/launcher:launcher_maker` produces launchers *for* Windows, but there is no reason why it must *run on* Windows. By making it runnable on all platforms, `*_binary` targets can be built *for* Windows from any platform assuming that a suitable cross-compiling C++ toolchain is available. Closes bazelbuild#23731. PiperOrigin-RevId: 679251350 Change-Id: I1b380d5b28a616ace88a3b049a2b4554aa209ae3
bazel-io
added
team-Rules-CPP
rickeylev
approved these changes
Sep 26, 2024
Merged
via the queue into
bazelbuild:release-7.4.0
with commit Sep 27, 2024
653f8d3
51 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//tools/launcher:launcher_makerproduces launchers for Windows, but there is no reason why it must run on Windows. By making it runnable on all platforms,*_binarytargets can be built for Windows from any platform assuming that a suitable cross-compiling C++ toolchain is available.Closes #23731.
PiperOrigin-RevId: 679251350
Change-Id: I1b380d5b28a616ace88a3b049a2b4554aa209ae3
Commit 108f117