Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rules_java 7.12.1 (w/ java_tools v13.9) #23811

Closed
wants to merge 1 commit into from
Closed

rules_java 7.12.1 (w/ java_tools v13.9) #23811

wants to merge 1 commit into from

Conversation

hvadehra
Copy link
Member

No description provided.

@hvadehra hvadehra marked this pull request as ready for review September 30, 2024 15:49
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 30, 2024
@hvadehra hvadehra mentioned this pull request Sep 30, 2024
Closed
@iancha1992 iancha1992 added the team-Rules-Java Issues for Java rules label Sep 30, 2024
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 1, 2024
@hvadehra hvadehra closed this Oct 2, 2024
@hvadehra hvadehra deleted the hvd_p23738 branch October 2, 2024 13:14
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 2, 2024
@iancha1992
Copy link
Member

@hvadehra I don't think this is merged. Are you creating another PR for it?

@hvadehra hvadehra restored the hvd_p23738 branch October 2, 2024 20:46
@hvadehra
Copy link
Member Author

hvadehra commented Oct 2, 2024

My bad, I thought the internal change was submitted, restored the branch.

@hvadehra hvadehra reopened this Oct 2, 2024
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 2, 2024
@hvadehra hvadehra added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 2, 2024
@copybara-service copybara-service bot closed this in 58f263c Oct 3, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 3, 2024
@hvadehra hvadehra deleted the hvd_p23738 branch October 3, 2024 10:28
This was referenced Oct 3, 2024
Closed
Closed
@iancha1992
Copy link
Member

@bazel-io fork 7.4.0

@bazel-io bazel-io mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hvadehra @iancha1992 @meteorcloudy