Support %workspace% in execution log paths #23813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the execution logs were always written to relative paths. This caused an issue if you put this flag in your `.bazelrc` and expected the log to be produced in a relative directory. You can now use `%workspace%` to handle writing to the root of your workspace. Fixes #22267
github-actions
bot
added
the
awaiting-review
|
@bazel-io fork 7.4.0 |
|
macOS failure here appears unrelated |
iancha1992
added
team-Configurability
|
it is as far as i'm concerned! |
iancha1992
added
awaiting-PR-merge
meisterT
approved these changes
Oct 4, 2024
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Oct 4, 2024
Previously the execution logs were always written to relative paths. This caused an issue if you put this flag in your `.bazelrc` and expected the log to be produced in a relative directory. You can now use `%workspace%` to handle writing to the root of your workspace. Fixes bazelbuild#22267 Closes bazelbuild#23813. PiperOrigin-RevId: 682196916 Change-Id: I5f6fe3c72cfc3fe9a891e0d44440cb49bbc787d8
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Previously the execution logs were always written to relative paths. This caused an issue if you put this flag in your `.bazelrc` and expected the log to be produced in a relative directory. You can now use `%workspace%` to handle writing to the root of your workspace. Fixes #22267 Closes #23813. PiperOrigin-RevId: 682196916 Change-Id: I5f6fe3c72cfc3fe9a891e0d44440cb49bbc787d8 Commit 9aaeb9f Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the execution logs were always written to relative paths.
This caused an issue if you put this flag in your
.bazelrcandexpected the log to be produced in a relative directory. You can now use
%workspace%to handle writing to the root of your workspace.Fixes #22267