Add opt-in set_soname feature #23839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows correctly setting the `soname` for shared libraries on Linux. This is useful for similar reasons to the macOS `set_install_name` feature. Fixes bazelbuild#18798
github-actions
bot
added
team-Rules-CPP
comius
approved these changes
Oct 2, 2024
comius
added
awaiting-PR-merge
|
@bazel-io fork 7.4.0 |
|
FWIW we might want to make this the default in the future, as it is also already the default on macOS @ HEAD |
github-actions
bot
removed
the
awaiting-PR-merge
keith
added a commit
to keith/bazel
that referenced
this pull request
Oct 3, 2024
This allows correctly setting the `soname` for shared libraries on Linux. This is useful for similar reasons to the macOS `set_install_name` feature. Fixes bazelbuild#18798 Closes bazelbuild#23839. PiperOrigin-RevId: 681847016 Change-Id: I2d3584c9d91564b41c2501e6664e2956f9760e41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows correctly setting the
sonamefor shared libraries onLinux. This is useful for similar reasons to the macOS
set_install_namefeature.Fixes #18798