-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set oldest_content_accepted for remote downloader requests without the checksum #23970
Conversation
@@ -90,6 +93,8 @@ public class GrpcRemoteDownloader implements AutoCloseable, Downloader { | |||
// value when both are present. | |||
private static final String QUALIFIER_HTTP_HEADER_URL_PREFIX = "http_header_url:"; | |||
|
|||
private Clock clock = Clock.systemUTC(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of storing a clock here, you can use com.google.devtools.build.lib.clock.BlazeClock#instance
, which is still injectable for testing purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip. I replaced the usage of java.time.Clock
with com.google.devtools.build.lib.clock.BlazeClock
and made appropriate changes to remove the manual property injection into the GrpcRemoteDownloader
class.
dd41a68
to
be0c92a
Compare
be0c92a
to
9fe8968
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/main/java/com/google/devtools/build/lib/remote/downloader/GrpcRemoteDownloader.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@coeuvre Please take a look |
@bazel-io fork 8.0.0 |
…e checksum This PR address the bazelbuild#23932 issue with remote downloader. Closes bazelbuild#23970. PiperOrigin-RevId: 686180819 Change-Id: Ia36c5793622bd1ac1fdaa9ef1326ddc385a5a01f
This PR address the #23932 issue with remote downloader.