[8.0.0] Lberki cherrypick 8.0.0 ignored subdirectories #23999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the mechanical part of the change. It's not, strictly speaking, necessary, but given that the that set of path fragments will not be interpreted as a set of path fragments soon, I think it's better to be explicit. An ancillary benefit is that now one can search for the new object to figure out which parts of the code handle the concept of "ignored subdirectories". Progress towards #7093 . RELNOTES: None. PiperOrigin-RevId: 686046437 Change-Id: I4191297c9b1e5a6599d4c5f8eb2c80fae14ac220
…re other than diff awareness. Progress towards #9037. RELNOTES: None. PiperOrigin-RevId: 686063047 Change-Id: If27b64213ed51f0b5f8c361c657b9bba2d7511f6
Progress towards #9037. RELNOTES: None. PiperOrigin-RevId: 686074081 Change-Id: I919a452eb27d149b8e52c9c8188df294521fe347
Progress towards #7093. RELNOTES: None. PiperOrigin-RevId: 686088272 Change-Id: I17ea2481ed58b76352ff1939b78ba93b8bdc9eac
This required a number of somewhat awkward .toRelative() calls, but the alternative would have been to make IgnoredSubdirectories either have all absolute paths or all relative paths (both prefixes and inputs) and this one seemed simpler. Progress towards #7093. RELNOTES: None. PiperOrigin-RevId: 686411349 Change-Id: I62b0b7f12801e7b44b6e064893c1dc0cb282badb
github-actions
bot
added
team-ExternalDeps
github-actions
bot
removed
the
awaiting-review
iancha1992
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed; for ease of further cherry-picking, it's probably a good idea to cherry-pick this big refactoring to 8.0.0 .