Fix a bug that PATH on Windows will sometimes get overwritten (#152)

* Fix a bug that PATH env is overwritten if it's name is `Path` (on Windows). * Use strings.EqualFold instead of strings.ToUpper to do case-insensitive comparison.
bazelbuild · Aug 18, 2020 · 6f5ce4b · 6f5ce4b
1 parent 297a40a
commit 6f5ce4b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/bazelisk.go b/bazelisk.go
@@ -646,7 +646,7 @@ func prependDirToPathList(cmd *exec.Cmd, dir string) {
 		if len(splits) != 2 {
 			continue
 		}
-		if splits[0] == "PATH" {
+		if strings.EqualFold(splits[0], "PATH") {
 			found = true
 			cmd.Env[idx] = fmt.Sprintf("PATH=%s%s%s", dir, string(os.PathListSeparator), splits[1])
 			break