chore(buildifier): enable provider-params lint check (#326)

bazelbuild · Oct 3, 2023 · beba0f3 · beba0f3
1 parent 8e17eff
commit beba0f3
Show file tree

Hide file tree

Showing 11 changed files with 10 additions and 11 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -14,5 +14,3 @@ repos:
     hooks:
       - id: buildifier
       - id: buildifier-lint
-        args:
-          - --warnings=-provider-params
diff --git a/configurations/basic_build_setting/defs.bzl b/configurations/basic_build_setting/defs.bzl
@@ -1,5 +1,5 @@
 # buildifier: disable=module-docstring
-TemperatureInfo = provider(fields = ["type"])
+TemperatureInfo = provider(doc = "", fields = ["type"])
 
 temperatures = ["HOT", "LUKEWARM", "ICED"]
 

diff --git a/configurations/label_typed_build_setting/defs.bzl b/configurations/label_typed_build_setting/defs.bzl
@@ -1,5 +1,5 @@
 # buildifier: disable=module-docstring
-ToolInfo = provider(fields = ["type"])
+ToolInfo = provider(doc = "", fields = ["type"])
 
 # buildifier: disable=print
 def _toolbox_impl(ctx):

diff --git a/configurations/multi_arch_binary/defs.bzl b/configurations/multi_arch_binary/defs.bzl
@@ -47,7 +47,7 @@ foo_binary = rule(
     },
 )
 
-CpuInfo = provider(fields = ["value"])
+CpuInfo = provider(doc = "", fields = ["value"])
 
 def _impl(ctx):
     # Get the current cpu using `ctx.var` which contains a

diff --git a/configurations/select_on_build_setting/defs.bzl b/configurations/select_on_build_setting/defs.bzl
@@ -1,5 +1,5 @@
 # buildifier: disable=module-docstring
-FruitInfo = provider(fields = ["type"])
+FruitInfo = provider(doc = "", fields = ["type"])
 
 # buildifier: disable=print
 def _impl(ctx):

diff --git a/flags-parsing-tutorial/build_defs.bzl b/flags-parsing-tutorial/build_defs.bzl
@@ -1,5 +1,5 @@
 # buildifier: disable=module-docstring
-BuildSettingInfo = provider()
+BuildSettingInfo = provider(doc = "", fields = ["value"])
 
 def _string_imp(ctx):
     value = ctx.build_setting_value

diff --git a/rules/aspect/file_collector.bzl b/rules/aspect/file_collector.bzl
@@ -5,6 +5,7 @@ For more information about aspects, see the documentation:
 """
 
 CollectedFileInfo = provider(
+    doc = "",
     fields = {"files": "collected files"},
 )
 

diff --git a/rules/depsets/foo.bzl b/rules/depsets/foo.bzl
@@ -1,5 +1,5 @@
 # buildifier: disable=module-docstring
-FooFilesInfo = provider("transitive_sources")
+FooFilesInfo = provider(doc = "", fields = ["transitive_sources"])
 
 def get_transitive_srcs(srcs, deps):
     """Obtain the source files for a target and its transitive dependencies.

diff --git a/rules/mandatory_provider/sum.bzl b/rules/mandatory_provider/sum.bzl
@@ -6,7 +6,7 @@ file. This shows how to transfer information from a dependency to its
 dependents.
 """
 
-NumberInfo = provider("number")
+NumberInfo = provider(doc = "", fields = ["number"])
 
 def _impl(ctx):
     result = ctx.attr.number

diff --git a/rules/optional_provider/sum.bzl b/rules/optional_provider/sum.bzl
@@ -6,7 +6,7 @@ file. This shows how to transfer information from a dependency to its
 dependents. Dependencies are not required to provide a number.
 """
 
-NumberInfo = provider("number")
+NumberInfo = provider(doc = "", fields = ["number"])
 
 def _impl(ctx):
     result = ctx.attr.number

diff --git a/rules/runfiles/library.bzl b/rules/runfiles/library.bzl
@@ -7,7 +7,7 @@ such a scenario.
 
 # When possible, use custom providers to manage propagating information
 # between dependencies and their dependers.
-RuntimeRequiredFilesInfo = provider(fields = ["file", "data_files"])
+RuntimeRequiredFilesInfo = provider(doc = "", fields = ["file", "data_files"])
 
 def _library_impl(ctx):
     # Expand the label in the command string to a runfiles-relative path.