-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issues when bazel is used alongside cmake #6770
base: master
Are you sure you want to change the base?
Conversation
CC @TomatorCZ |
@TomatorCZ PSW for bazel seems broken in 243 not sure what causes this. As far as I can tell |
@tpasternak The normal banner is a bit different and only checks if the current project is bazel or not. Also it should be possible to dismiss the default banner. |
Sorry I didn't get it |
A required fix in CLion is on master - waiting for next EAP due to API changes. |
LGTM |
unregisterGenericProvider(project) | ||
|
||
if (!providerRegistered) { | ||
registerSpecificProvider(); | ||
} | ||
providerRegistered = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use application service for this thing?
Description of this change
If the file already belongs to a cmake project the bazel import fix is also shown by the PSW and if the project is reopend some classes are registered twice.