Use aspect to toolchain propagation to collect information of Cc and Kotlin toolchains #6928
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
added
the
copybara-exported
copybara-service
bot
force-pushed
the
test_689520709
branch
12 times, most recently
from
f2fb9f6
to
5117a50
Compare
copybara-service
bot
changed the title
…Kotlin toolchains the `_toolchain` attribute is removed by `rules_kotlin` and `_cc_toolchain` attribute is planned to be removed by `rules_cc`. This change uses the new approach of aspect to toolchains propagation based on toolchain types instead. This feature is available in Blaze but not in all Bazel versions. Therefore, we keep using the old attribute-based approach for Bazel as the toolchain attributes will still be there for Bazel. PiperOrigin-RevId: 689520709
copybara-service
bot
force-pushed
the
test_689520709
branch
from
5117a50
to
24d39fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use aspect to toolchain propagation to collect information of Cc and Kotlin toolchains
the
_toolchainattribute is removed byrules_kotlinand_cc_toolchainattribute is planned to be removed byrules_cc. This change uses the new approach of aspect to toolchains propagation based on toolchain types instead. This feature is available in Blaze but not in all Bazel versions. Therefore, we keep using the old attribute-based approach for Bazel as the toolchain attributes will still be there for Bazel.