Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo_build_script: De-duplicate _pwd_flags implementation #2956

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cargo_build_script: De-duplicate _pwd_flags implementation #2956

wants to merge 2 commits into from
+18 −41

Conversation

vitalybuka
Copy link
Contributor

@vitalybuka vitalybuka commented Oct 21, 2024 •
edited
Loading

This reverts #2925 to reland #2911 and #2922, and
fixes the code to pass the test added with #2936 (the
second commit of the PR).

The test from #2936 will fail with pure revert.

@vitalybuka vitalybuka changed the title mypatches cargo_build_script: De-duplicate _pwd_flags implementation Oct 21, 2024
@vitalybuka
Copy link
Contributor Author

@krasimirgg

This PR provides optional refactoring.
The code is currently written in a longer, but simpler style.
This refactors the code to be more concise by applying the DRY principle.
It is at the owner's discretion whether to merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vitalybuka