Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update 2024 07 12 #93

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"development": {
"plugins": [
"istanbul",
"transform-class-properties"
"@babel/plugin-transform-class-properties"
],
"minified": false
},
Expand Down
7 changes: 6 additions & 1 deletion .eslintrc.js → .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,12 @@ module.exports = {

"max-params": ["error", 6],

"no-console": "off"
"no-console": "off",

"comma-dangle": [
"error", "always-multiline"
],
// "sourceType": "module"

// "max-statements": ["error", 30]

Expand Down
29 changes: 29 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Build 🛠️

on:
workflow_dispatch: # can call manually
push:
branches:
- master
pull_request:

jobs:
test:
name: Run the tests
strategy:
matrix:
node-version: ['18.x', '20.x']

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci
- run: npm run lint
- run: npm run build
- run: npm run test
10 changes: 8 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
[![Build 🛠️](https://github.com/bbc/adhere-lib/actions/workflows/build.yml/badge.svg?branch=main&event=status)](https://github.com/bbc/adhere-lib/actions/workflows/build.yml)

# adhere-lib
Javascript library for processing AD profile TTML2 and presenting with an HTML video element

Expand All @@ -20,9 +22,13 @@ A web page showcasing adhere-lib is available at https://bbc.github.io/Adhere/
## Setup

```Shell
nvm install 14.16.0
nvm use 14.16.0
nvm install 20.11.0
nvm use 20.11.0
nvm install-latest-npm
```

(latest npm is currently 10.8.1)

`cd` to project dir

```Shell
Expand Down
6 changes: 3 additions & 3 deletions build-pr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
set -e

source /usr/local/nvm/nvm.sh
nvm install 12.12.0
nvm use 12.12.0

nvm install 20.11.0
nvm use 20.11.0
nvm install-latest-npm

# Install & Build
npm install
Expand Down
5 changes: 3 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
set -e

source /usr/local/nvm/nvm.sh
nvm install 12.12.0
nvm use 12.12.0
nvm install 20.11.0
nvm use 20.11.0
nvm install-latest-npm

# Install & Build
npm install
Expand Down
3,696 changes: 55 additions & 3,641 deletions dist/bin/js/bundle.js

Large diffs are not rendered by default.

Loading