Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NASAA-205] - Send top stories experiment analytics events #12057

Draft
wants to merge 2 commits into
base: nasaa-create-amp-experiment
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/app/components/ATIAnalytics/amp/ampAnalyticsJson.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@

import { ATIAnalyticsProps } from '../types';

const ampAnalyticsJson = ({ baseUrl, pageviewParams }: ATIAnalyticsProps) => ({
const ampAnalyticsJson = ({
baseUrl,
pageviewParams,
eventsParams,
}: ATIAnalyticsProps) => ({
transport: {
beacon: false,
xhrpost: false,
Expand All @@ -13,8 +17,12 @@ const ampAnalyticsJson = ({ baseUrl, pageviewParams }: ATIAnalyticsProps) => ({
requests: {
base: baseUrl,
pageview: '${base}' + pageviewParams,
...eventsParams?.requests,
},
triggers: {
trackPageview: { on: 'visible', request: 'pageview' },
...eventsParams?.triggers,
},
triggers: { trackPageview: { on: 'visible', request: 'pageview' } },
});

export default ampAnalyticsJson;
6 changes: 5 additions & 1 deletion src/app/components/ATIAnalytics/amp/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,17 @@ const JsonInlinedScript = (data: AMPAnalyticsData) => (
/>
);

const AmpATIAnalytics = ({ pageviewParams }: ATIAnalyticsProps) => {
const AmpATIAnalytics = ({
pageviewParams,
eventsParams,
}: ATIAnalyticsProps) => {
return (
<amp-analytics>
{JsonInlinedScript(
getAmpAnalyticsJson({
baseUrl: getEnvConfig().SIMORGH_ATI_BASE_URL,
pageviewParams,
eventsParams,
}),
)}
</amp-analytics>
Expand Down
2 changes: 2 additions & 0 deletions src/app/components/ATIAnalytics/atiUrl/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ export const buildATIEventTrackUrl = ({
advertiserID,
url,
detailedPlacement,
variant,
}: ATIEventTrackingProps) => {
// on AMP, variable substitutions are used in the value and they cannot be
// encoded: https://github.com/ampproject/amphtml/blob/master/spec/amp-var-substitutions.md
Expand Down Expand Up @@ -323,6 +324,7 @@ export const buildATIEventTrackUrl = ({
advertiserID,
url,
detailedPlacement,
variant,
}),
wrap: false,
disableEncoding: true,
Expand Down
7 changes: 5 additions & 2 deletions src/app/components/ATIAnalytics/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import AmpATIAnalytics from './amp';
import { ATIProps } from './types';
import buildATIUrl from './params';

const ATIAnalytics = ({ data, atiData }: ATIProps) => {
const ATIAnalytics = ({ data, atiData, atiEventsData }: ATIProps) => {
const requestContext = useContext(RequestContext);
const serviceContext = useContext(ServiceContext);
const { isAmp } = requestContext;
Expand All @@ -23,7 +23,10 @@ const ATIAnalytics = ({ data, atiData }: ATIProps) => {
}

return isAmp ? (
<AmpATIAnalytics pageviewParams={pageviewParams} />
<AmpATIAnalytics
pageviewParams={pageviewParams}
eventsParams={atiEventsData}
/>
) : (
<CanonicalATIAnalytics pageviewParams={pageviewParams} />
);
Expand Down
12 changes: 12 additions & 0 deletions src/app/components/ATIAnalytics/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,19 @@ export interface ATIConfigurationDetailsProviders {
atiData?: ATIData;
}

export interface ATIEventsData {
requests?: {
[key: string]: string;
};
triggers?: {
[key: string]: object;
};
}

export interface ATIAnalyticsProps {
baseUrl?: string;
pageviewParams: string;
eventsParams?: ATIEventsData;
}

export interface ATIEventTrackingProps {
Expand All @@ -109,6 +119,7 @@ export interface ATIEventTrackingProps {
advertiserID?: string;
url?: string;
detailedPlacement?: string;
variant?: string;
}

export interface ATIPageTrackingProps {
Expand Down Expand Up @@ -136,4 +147,5 @@ export interface ATIPageTrackingProps {
export interface ATIProps {
data?: PageData;
atiData?: ATIData;
atiEventsData?: ATIEventsData;
}
16 changes: 15 additions & 1 deletion src/app/components/AmpExperiment/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ const AmpHead = () => (
</Helmet>
);

const AmpExperiment = ({ experimentConfig }: AmpExperimentProps) => {
const AmpExperiment = ({
experimentConfig,
analyticsConfig,
}: AmpExperimentProps) => {
return (
<>
<AmpHead />
Expand All @@ -43,6 +46,17 @@ const AmpExperiment = ({ experimentConfig }: AmpExperimentProps) => {
dangerouslySetInnerHTML={{ __html: JSON.stringify(experimentConfig) }}
/>
</amp-experiment>
{analyticsConfig && (
<amp-analytics>
<script
type="application/json"
/* eslint-disable-next-line react/no-danger */
dangerouslySetInnerHTML={{
__html: JSON.stringify(analyticsConfig),
}}
/>
</amp-analytics>
)}
</>
);
};
Expand Down
9 changes: 7 additions & 2 deletions src/app/pages/ArticlePage/ArticlePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,14 @@ import { ComponentToRenderProps, TimeStampProps } from './types';
import AmpExperiment from '../../components/AmpExperiment';
import {
experimentTopStoriesConfig,
getExperimentAnalyticsConfig,
getExperimentTopStories,
ExperimentTopStories,
} from './experimentTopStories/helpers';

const ArticlePage = ({ pageData }: { pageData: Article }) => {
const { isApp, pageType, service, isAmp, id } = useContext(RequestContext);
const { isApp, pageType, service, isAmp, id, env } =
useContext(RequestContext);

const {
articleAuthor,
Expand Down Expand Up @@ -229,7 +231,10 @@ const ArticlePage = ({ pageData }: { pageData: Article }) => {
{shouldEnableExperimentTopStories && (
<AmpExperiment experimentConfig={experimentTopStoriesConfig} />
)}
<ATIAnalytics atiData={atiData} />
<ATIAnalytics
atiData={atiData}
atiEventsData={getExperimentAnalyticsConfig({ env, service })}
/>
<ChartbeatAnalytics
sectionName={pageData?.relatedContent?.section?.name}
title={headline}
Expand Down
75 changes: 74 additions & 1 deletion src/app/pages/ArticlePage/experimentTopStories/helpers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,91 @@
import { jsx } from '@emotion/react';
import { OptimoBlock } from '#app/models/types/optimo';
import { TopStoryItem } from '#app/pages/ArticlePage/PagePromoSections/TopStoriesSection/types';
import { buildATIEventTrackUrl } from '#app/components/ATIAnalytics/atiUrl';
import { Services, Environments } from '#app/models/types/global';
import TopStoriesSection from '../PagePromoSections/TopStoriesSection';
import styles from './index.styles';

const experimentName = 'topStoriesExperiment';

export const experimentTopStoriesConfig = {
topStoriesExperiment: {
[experimentName]: {
variants: {
control: 50,
show_at_halfway: 50,
},
},
};

const getStatsDestinationKey = ({
env,
service,
}: {
service: Services;
env: Environments;
}) => {
if (env !== 'live') {
return service === 'news' ? 'NEWS_PS_TEST' : 'SPORT_PS_TEST';
}

return service === 'news' ? 'NEWS_PS' : 'SPORT_PS';
};

// SOURCE_URL and VARIANT(${experimentName}) are replaced with their actual values via AMP's variable substitution: https://github.com/ampproject/amphtml/blob/main/docs/spec/amp-var-substitutions.md
const buildTopStoriesEventUrl = ({
type,
env,
service,
}: {
type: 'view' | 'click';

env: Environments;
service: Services;
}) => {
return buildATIEventTrackUrl({
campaignID: 'article',
componentName: 'top-stories-section',
pageIdentifier: 'SOURCE_URL',
platform: 'amp',
producerId: '64',
statsDestination: `${getStatsDestinationKey({ env, service })}`,
variant: `${experimentName}:VARIANT(${experimentName})`,
type,
});
};

export const getExperimentAnalyticsConfig = ({
env,
service,
}: {
env: Environments;
service: Services;
}) => {
return {
requests: {
topStoriesView: buildTopStoriesEventUrl({ type: 'view', env, service }),
topStoriesClick: buildTopStoriesEventUrl({ type: 'click', env, service }),
},
triggers: {
trackTopStoriesView: {
on: 'visible',
request: 'topStoriesView',
visibilitySpec: {
selector: `[class*='experimentTopStoriesSection']`,
visiblePercentageMin: 20,
totalTimeMin: 500,
continuousTimeMin: 200,
},
},
trackTopStoriesClick: {
on: 'click',
request: 'topStoriesClick',
selector: 'a',
},
},
};
};

const enableExperimentTopStories = ({
topStoriesContent,
isAmp,
Expand Down
Loading