Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shaka preload #732

Merged
merged 4 commits into from
Aug 19, 2024
Merged

feat: add shaka preload #732

merged 4 commits into from
Aug 19, 2024

Conversation

yakca
Copy link
Member

@yakca yakca commented Aug 13, 2024

Details

Adds the recent shaka player feature preload to the DOM player engine, used for DASH and non-native HLS. The preload step fetches further media segments, ahead of playback, than a default load resulting in a better transition between media.

Fairly easy win as story objects already contains and loads the next media in the narrative before playback, so preloading is a limited but impactful code change.

Also includes shaka-player version bump to 4.10.8

Ticket / issue URL

Ticket / issue URL: https://jira.dev.bbc.co.uk/browse/PRODTOOLS-4027

PR Checks

(tick as appropriate)

@yakca yakca requested a review from andy-brown August 13, 2024 11:20
Copy link
Contributor

@andy-brown andy-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and with our published Insta story - all works fine and see more content preloaded.

@yakca yakca merged commit c59e957 into main Aug 19, 2024
2 checks passed
@yakca yakca deleted the add-shaka-preload branch August 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants