Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Define ending position column #130

Open
smacker opened this issue Jan 9, 2018 · 4 comments
Open

Define ending position column #130

smacker opened this issue Jan 9, 2018 · 4 comments

Comments

@smacker
Copy link
Contributor

smacker commented Jan 9, 2018

There is an inconsistency in java&python drivers. EndPosition.End.Col for java driver returns the position of next character and python driver returns the position of the last character. For example for code print node will have EndPosition.End.Col = 6 for java and EndPosition.End.Col = 5 for python.
Currently, it isn't defined what driver should return, so it depends on native AST.
Position should be defined and later fixed in drivers accordingly.

@bzz
Copy link
Contributor

bzz commented Jun 26, 2018

\cc @dennwc @juanjux what do you guys think?

@dennwc
Copy link
Member

dennwc commented Jun 26, 2018

It should be fixed as a part of v2 release. We are almost there.

@bzz
Copy link
Contributor

bzz commented Jun 26, 2018

We are experiencing this with Golang driver as well in gitbase-playground.

🤞 Waiting for v2 😄

@dennwc
Copy link
Member

dennwc commented Jun 26, 2018

Aware of problems with Go drivers, and it's fixed upstream as well :) Tested with bblfsh/uast-viewer#19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants