Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to pytorch 1.1.0a0+ec8b1c9 #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

h3jia
Copy link

@h3jia h3jia commented Feb 14, 2019

No description provided.

@h3jia
Copy link
Author

h3jia commented Feb 15, 2019

Now it builds libtorch as well.

cd build_libtorch
BUILD_TORCH=ON ONNX_NAMESPACE=onnx_torch bash ../tools/build_pytorch_libs.sh --use-nnpack caffe2
} && {
echo -e "\nSuccessfully built libtorch at `dirname $PWD`/torch/lib/tmp_install\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. but why not install libtorch to the proper directory? Is it because there is a conflict?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that in fact it's also built in torch/, and they've removed /torch/lib/tmp_install in a later commit. I just tried the latest version, and pytorch itself was built successfully. But they changed the way to build libtorch, and there's a bug that I don't know how to fix. I'm gonna ask them before updating this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants