Fix/wfs connect timeout 246 - #247
Merged
Merged
Conversation
A hardcoded 10s connect timeout, introduced when WFS requests were consolidated into _request(), can trip on GitHub-hosted runners whose TCP handshake to openmaps.gov.bc.ca sometimes exceeds 10s, causing every retry attempt to fail identically. Dropping the connect timeout (read timeout unchanged) restores the pre-existing unbounded-connect behavior, matching what requests/urllib3 do by default. Fixes #246 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
|
I'll merge and cut a new release. Failures seem to just be openmaps.gov.bc.ca issues with connections from GHA - which have generally been fine from this set of tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should fix primary download issue in #246 but I'm not yet sure why the catalogue is refusing connections to GHA runners.