[MDS-6169] PRR records not showing in minespace #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbusby-fw
reviewed
Sep 27, 2024
| if (!permitGuid) { | ||
| setCodeRequiredReports(mineReports); | ||
| setCRRPageData(pageData); | ||
| } else if (permitGuid) { |
There was a problem hiding this comment.
super minor, but this could probably just be an else
taraepp
reviewed
Sep 27, 2024
| @@ -0,0 +1,9 @@ | |||
| import { IMineReport } from "../.."; | |||
|
|
|||
| export interface IMineReportPageData { | |||
There was a problem hiding this comment.
check out core-web ReportsTable for IPageData<IMineReport>! Generic type for the same thing, so we don't need to create as many interfaces
|
|
|
matbusby-fw
approved these changes
Oct 2, 2024
henryoforeh-dev
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6169
fetchMineReportscall and pagination to handle CRR and PRR records separately.(below are not part of original ticket)