Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6114] Fix AMS bug #3268

Merged
merged 6 commits into from
Oct 17, 2024
Merged

[MDS-6114] Fix AMS bug #3268

merged 6 commits into from
Oct 17, 2024

Conversation

henryoforeh-dev
Copy link
Collaborator

Objective

MDS-6114

Why are you making this change? Provide a short explanation and/or screenshots

  • Fixed: Regions were displaying the ID instead of the region name.
  • Fixed: AMS submission bug where the incorporation number and address unit number attributes were omitted from the application object.

Note: The phone number extension was also identified as missing from the application object. However, this attribute is not included in the latest AMS documentation.

@henryoforeh-dev henryoforeh-dev changed the title [MDS-6114] fFx AMS bug [MDS-6114] Fix AMS bug Oct 17, 2024
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_common'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@henryoforeh-dev henryoforeh-dev merged commit 594ed87 into develop Oct 17, 2024
18 checks passed
@henryoforeh-dev henryoforeh-dev deleted the MDS-6114-fix-bug branch October 17, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants