[CHORE] - update VerificationMethod and .env-example #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on UNTPDCC and BCMinesActPermitCredential versions
update context reference to 0.5.0
Jsyro
added
the
👍 Ready for review
Jsyro
changed the title
stop using sovrin did, just use did:web from tdw server.
PatStLouis
reviewed
Oct 18, 2024
Comment on lines
+295
to
+296
| "CHIEF_PERMITTING_OFFICER_DID_WEB_VERIFICATION_METHOD", | ||
| "CHIEF_PERMITTING_OFFICER_DID_WEB_VERIFICATION_METHOD") |
There was a problem hiding this comment.
2nd params is the default if not provided.
App won't start if the second param is not provided.
slightly more developer friendly this way, .env-example has the appropriate values.
|
simensma-fresh
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Env changes have been made in openshift, should be made locally for DEV to match.
The verificationmethod had the wrong fragment in it, it was hard coded for how indy ledgers create diddocuments, but the tdw server does it differently, now take verification method and derive did from that.