forked from Learning-and-Intelligent-Systems/predicators
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement on Spot batch VLM predicate evaluation pipeline #285
Open
lf-zhao
wants to merge
48
commits into
master
Choose a base branch
from
lis-spot/update-vlm-predicate-pipeline
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; we need to figure out a better way to sync later!
…e-eval # Conflicts: # predicators/pretrained_model_interface.py # setup.py
…, only update these predicates
…dicate and VLMGroundAtom
…evaluate all VLM predicates on all objects to build init obs for env reset
…ld init obs that query all objects + all VLM predicates, update VLM ground atoms for visible objects, update VLM predicate classifiers
lf-zhao
requested review from
nkumar-bdai,
wmcclinton and
tsilver-bdai
as code owners
May 8, 2024 21:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new pipeline for VLM predicate evaluation / VLM classifier:
(Note: The previous PR #284 hasn't been merged and it carries over. That one was mainly for keeping record. This is what actually working on Spot)
Pipeline:
reset
, Spot builds initial obs and need to see all objects. We provide all VLM predicates and calculate all GroundAtom queries to evaluate for VLM classifiers, and save it as a dictionary.step
, Spot takes one step (skill level) and observes a set of new images, we only update VLM ground atoms of all VLM predicates but evaluate VLMGroundAtoms with the visible objects.reset
andstep
are done in batch manner: a batch contains all relevant VLM ground atoms and a collection of Spot camera images (e.g., 6 cameras), and return a list to parse.Command:
python predicators/main.py --spot_robot_ip 192.168.80.3 --spot_graph_nav_map b45-621 --env lis_spot_block_floor_env --approach spot_wrapper[oracle] --bilevel_plan_without_sim True --seed 0 --perceiver spot_perceiver --spot_vlm_eval_predicate True --vlm_eval_verbose True --num_train_tasks 0 --num_test_tasks 1
Modifications: