Drop support for Python 3.8; add support for Python 3.14 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsmith
reviewed
Oct 16, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
41
to
48
| continue-on-error: ${{ matrix.experimental || false }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12", "3.13-dev" ] | ||
| python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13", "3.14" ] | ||
| include: | ||
| - experimental: false | ||
| # Development Python can fail without failing the entire job | ||
| - python-version: "3.13-dev" | ||
| - python-version: "3.14" |
There was a problem hiding this comment.
I think it's clearer to keep the default experimental value in the matrix section, because:
- It allows you to derive all the values from that section alone.
- It avoids needing to repeat the default value if it was used in more than one place.
mhsmith
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.8 is EOL; 3.14.0a1 has been released.
PR Checklist: