Skip to content

Commit

Permalink
Fix finding BSS sections (#624)
Browse files Browse the repository at this point in the history 
* Fix finding BSS sections

There can be multiple NOBITS sections in an ELF binary - and we were taking
the first one as being the BSS section. In certain cases this doesn't work
(including the latest python 3.12 binary in conda) - since there can
be '.tbss' or '.sbss' sections instead.

Fix by performing an additional filter step using the section name.

* fix windows build with newer indicatif
  • Loading branch information
@benfred
benfred authored Oct 23, 2023
1 parent d1ac9a9 commit 75adc45
Show file tree
Hide file tree
Showing 4 changed files with 118 additions and 83 deletions.
Loading

0 comments on commit 75adc45

Please sign in to comment.