(win, python >= 3.10) Fix symbol address resolution #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhramov
commented
Jul 13, 2024
Cargo.toml
Outdated
| @@ -35,8 +35,9 @@ serde_derive = "1.0" | |||
| serde_json = "1.0" | |||
| rand = "0.8" | |||
| rand_distr = "0.4" | |||
| remoteprocess = {version="0.4.12", features=["unwind"]} | |||
| remoteprocess = { git = "https://github.com/akhramov/remoteprocess", branch = "feature/windows-aarch64" } | |||
There was a problem hiding this comment.
to-do: Unrelated to this effort. Remove this, needed on my machine only, to be upstreamed in benfred/remoteprocess#89
For PE images we use file offsets to calculate symbol addresses in memory. However PE loader uses RVAs (relative virtual addresses) instead, so the current approach breaks for newer python releases. This change tweaks windows symbol address resolution to rely on RVAs instead of file offsets.
akhramov
force-pushed
the
fix/interpreter-location-pe-image
branch
from
415d0d9
to
5596f94
Compare
akhramov
force-pushed
the
fix/interpreter-location-pe-image
branch
from
dedb53c
to
40be901
Compare
akhramov
force-pushed
the
fix/interpreter-location-pe-image
branch
from
40be901
to
67477ae
Compare
|
nice try, waiting for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PE images we use file offsets to calculate symbol addresses in memory. However PE loader uses RVAs (relative virtual addresses) instead, so the current approach breaks for newer python releases.
This change tweaks windows symbol address resolution to rely on RVAs instead of file offsets.