-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove build.rs #689
base: master
Are you sure you want to change the base?
Remove build.rs #689
Conversation
Where is the unwind feature turned on then? |
When using py-spy as rust library crate, we can enable BTW, there's no code make use of |
Yeah but that pull request didn't actually update anything to use the
Yeah that's why it's written as a custom cfg and we'll probably want to revert the feature change and do Alternatively, we need to at least specify the feature per platform during builds. Edit: Looks like @benfred made this change in #691. I don't have strong feelings about which pattern to use. It depends how critical having unwind enabled is, I guess, since people will undoubtably build and test without it enabled accidentally when it's an opt-in feature. |
84b25b2
to
2a679f3
Compare
Hi @zanieb, |
Afeter commit 5820bf6, build.rs has no use anymore, so remove. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Enable feature `unwind` by default, user can disable it by using: `cargo build --no-default-features` Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Afeter commit 5820bf6, build.rs has no use anymore, so remove.