Fix generating enum fields having values of uppercase letters #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennett-treptow
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
Awesome, thanks for contributing @kevinb1989!
These changes have been released in version 4.3.2
You are very welcomed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I have started a new side project, utilizing the existing sakila database.
The
film.ratingfield is ofenumtype with the following possible values:G,PG,PG-13,R,NC-17.When I generate the migrations for the database, this is the statement for the
film.ratingfield:So all possible values are converted to lower case.
The fix is simple, all test cases pass. But I think this could be a breaking change.
Pls let me know if I need to do anything else.