Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Chrom(e|ium) if the Firefox driver for selenium isn't available #317

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

valholl
Copy link

@valholl valholl commented Jan 5, 2024

Installing the selenium driver for Firefox under Debian is a bit of a pain, so when trying to run the tests locally I've found it easier to change the code to fallback to the Chromium driver if using the Firefox one fails.

As a Firefox user myself (for everything else) I would consider it extremely reasonable if this PR was refused, but I felt it was right to submit it in case it was useful for somebody else.

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (36d882d) 70.33% compared to head (cd9045f) 70.25%.

Files Patch % Lines
src/bepasty/tests/test_website.py 37.50% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   70.33%   70.25%   -0.09%     
==========================================
  Files          44       44              
  Lines        2623     2629       +6     
==========================================
+ Hits         1845     1847       +2     
- Misses        778      782       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit fce1806 into bepasty:master Jan 5, 2024
6 checks passed
@ThomasWaldmann
Copy link
Contributor

Thanks for the PR!

Good to have it if it makes life easier for some developers.

Chromium should be rather ok as it does not have the problematic components which Chrome has. But for automated testing use I guess they would not be that problematic anyway.

@valholl
Copy link
Author

valholl commented Jan 5, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants