release 1.5.1 add support for lines without z values

bertt · Aug 8, 2024 · 5290551 · 5290551
1 parent 3dd61da
commit 5290551
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -99,6 +99,8 @@ wkx-sharp - https://github.com/cschwarz/wkx-sharp for handling geometries
 
 ## History
 
+2024-08-08: release 1.5.1: add support for lines without z (assuming z=0)
+
 2024-07-30: release 1.5.0: to .NET 8 + use LineCurve instead of CatmullRomCurve (better performance + more accurate)
 
 2024-02-20: release 1.4.3: fix lines of 2 points

diff --git a/src/triangulator.tests/TriangulateTests.cs b/src/triangulator.tests/TriangulateTests.cs
@@ -23,6 +23,20 @@ public void TriangulateMultiLineString()
 
         }
 
+        [Test]
+        public void TriangulateLineWithoutZ()
+        {
+            var wkt = "LINESTRING (1 0, 20 0)";
+            var line = (LineString)Geometry.Deserialize<WktSerializer>(wkt);
+
+            var triangles = Triangulator.Triangulate(line, 2);
+
+            Assert.That(triangles.Geometries.Count == 16);
+
+            GltfCreator.CreateGltf(triangles, @"carmullromcurves.gltf");
+        }
+
+
         [Test]
         public void TriangulateLineOnly2Points()
         {

diff --git a/src/triangulator/Triangulator.cs b/src/triangulator/Triangulator.cs
@@ -74,7 +74,8 @@ public static MultiPolygon Triangulate(LineString lineString, float radius = 1,
             var points = new List<THREE.Vector3>();
             foreach (var point in lineString.Points)
             {
-                points.Add(new THREE.Vector3((float)point.X, (float)point.Y, (float)point.Z));
+                var z = point.Z ?? 0;
+                points.Add(new THREE.Vector3((float)point.X, (float)point.Y, (float)z));
             }
 
             return points;

diff --git a/src/triangulator/triangulator.csproj b/src/triangulator/triangulator.csproj
@@ -13,11 +13,11 @@
     <PackageTags>wkb triangulate earcut</PackageTags>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <Copyright>Bert Temme</Copyright>
-    <Version>1.5.0</Version>
-    <PackageReleaseNotes>Add lines support</PackageReleaseNotes>
+    <Version>1.5.1</Version>
+	<AssemblyVersion>1.5.1.0</AssemblyVersion>
+	<FileVersion>1.5.1</FileVersion>
+	<PackageReleaseNotes>Add lines support</PackageReleaseNotes>
     <RootNamespace>Triangulate</RootNamespace>
-    <AssemblyVersion>1.5.0.3</AssemblyVersion>
-    <FileVersion>1.5.0</FileVersion>
   </PropertyGroup>
 
   <ItemGroup>