-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the skip pre-analysis parameter logic #337
Comments
With internal discussion we talked about an automatic random subsetting of files to generate an empirical library. we favored subsetting a 'maximum number of files', rather than to a 'percentage subset', since it offers both
Suggested implementation:
(not real code ... just meant to show where in the workflow it would happen)
|
As @jspaezp mentioned, we should refine the current proposal for skipping the assembly library and pre-analysis using the following logic:
This will help us to perform the pre-analysis on a certain number of files only depending on the size of the cluster and the resources, by making it false, it will use always all the files. For really large datasets users can define the number of files they want to use. My main questions is how the previous PR #335 by @jspaezp overlaps with this idea. In the previous PR the user needs to do job1 and job2 configurations manually? |
This has been done. |
Description of feature
In the following, PR #335 @jspaezp introduced the possibility to perform the DIA without the preanalysis step. It would be great to use the SDRF information to sub-select a few RAW files to perform the preanalysis which is better to generate the final results. Some of the SDRF columns that could be selected to generate the preanalysis are:
The text was updated successfully, but these errors were encountered: