Skip to content

Commit

Permalink
Merge pull request #20 from IamDavidovich/tracing
Browse files Browse the repository at this point in the history
Update ot-tracer-sampled to use 'true' and 'false' instead of '0' and '1'
  • Loading branch information
splittingred authored May 31, 2023
2 parents a2bfee3 + 0fe8cee commit b400f02
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ Changelog for the gruf-lightstep gem.

### Pending Release

- Use default value of `'true'` for the `ot-tracer-sampled` value in the client interceptor instead of `'1'`

### 1.7.0

- Add support for Ruby 3.2
Expand Down
2 changes: 1 addition & 1 deletion lib/gruf/lightstep/client_interceptor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def call(request_context:)
logger.debug "[gruf-lightstep] Injecting current active span #{span_data[:span_guid]} into outbound request context for #{request_context.method_name}"
request_context.metadata['ot-tracer-spanid'] = span_data[:span_guid].to_s
request_context.metadata['ot-tracer-traceid'] = span_data[:trace_guid].to_s
request_context.metadata['ot-tracer-sampled'] = '1'
request_context.metadata['ot-tracer-sampled'] = 'true'
end

yield
Expand Down

0 comments on commit b400f02

Please sign in to comment.