Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding cubi-tk snappy itransfer_sv_calling #213

Merged

Conversation

Nicolai-vKuegelgen
Copy link
Contributor

Adding a new command to transfer all outout from snappy's sv_calling or sv_calling_targeted steps.
Includes autodetection of which step was run and autodetection of all used sv callers from snappy config.

@Nicolai-vKuegelgen Nicolai-vKuegelgen linked an issue Jan 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b7fd7f1) 80.51% compared to head (7d898a9) 80.87%.
Report is 3 commits behind head on main.

❗ Current head 7d898a9 differs from pull request most recent head fea0fed. Consider uploading reports for the commit fea0fed to get more accurate results

Files Patch % Lines
cubi_tk/snappy/itransfer_sv_calling.py 95.83% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   80.51%   80.87%   +0.35%     
==========================================
  Files         102      104       +2     
  Lines        7966     8130     +164     
==========================================
+ Hits         6414     6575     +161     
- Misses       1552     1555       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cubi_tk/snappy/common.py Outdated Show resolved Hide resolved
cubi_tk/snappy/itransfer_sv_calling.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sellth sellth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicolai-vKuegelgen Nicolai-vKuegelgen merged commit 5a00e40 into main Jan 26, 2024
4 checks passed
@Nicolai-vKuegelgen Nicolai-vKuegelgen deleted the 211-need-a-cubi-tk-snappy-itransfer-sv-calling-module branch January 26, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a cubi-tk snappy itransfer-sv-calling module
2 participants