Skip to content

Commit

Permalink
Update nf-core - Add missing linkify dependency (#51762)
Browse files Browse the repository at this point in the history
* Add missing linkify dependency

The bioconda version of nf-core tools produced errors
when running commands that launched the trogon TUI.
The reason was the missing package linkify,
which gets pulled in as a dependency of textual in the PyPi
build, but not in the conda-forge recipe.
See https://github.com/Textualize/textual/blob/22770300252deb28d266fe4ed4766d6e2a2f5dd2/pyproject.toml#L44,
https://github.com/conda-forge/textual-feedstock/blob/main/recipe/meta.yaml
and nf-core/tools#3257.

* Pin linkify version

Code Rabbit AI suggestion:
The textual package version 0.71.0 depends on
markdown-it-py[linkify]>=2.1.0, which in turn
requires linkify-it-py>=2.0.0.

However, checking the actual dependencies of
markdown-it-py, it seems it wants linkify-it-py
to be >=1,<3.

* Update build number

* fix typo

---------

Co-authored-by: Joshua Zhuang <71105179+mencian@users.noreply.github.com>
  • Loading branch information
pmoris and mencian authored Oct 29, 2024
1 parent 70144b0 commit f388436
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion recipes/nf-core/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ source:

build:
noarch: python
number: 0
number: 1
script: "touch requirements.txt && {{ PYTHON }} -m pip install . --no-deps --no-build-isolation --no-cache-dir -vvv"
entry_points:
- nf-core=nf_core.__main__:run_nf_core
Expand Down Expand Up @@ -50,6 +50,7 @@ requirements:
- ruamel.yaml
- tabulate
- textual ==0.71.0
- linkify-it-py >=1,<3
- trogon
- nextflow >=24.04.4
- nf-test
Expand Down

0 comments on commit f388436

Please sign in to comment.