fix expct for categorical data

bips-hb · Jun 3, 2024 · aa95af7 · aa95af7
1 parent 151ddf2
commit aa95af7
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/R/expct.R b/R/expct.R
@@ -204,9 +204,8 @@ expct <- function(
         psi <- rbind(psi_cond, psi_uncond_relevant)
       }
       psi[NA_share == 1, wt := 0]
-      psi[prob < 1, prob := sum(wt * prob)/sum(wt), by = .(c_idx, variable, val)]
-      cat <- setDT(psi)[, .SD[which.max.random(prob)], by = .(c_idx, variable)]
-      cat <- unique(cat[, .(c_idx, variable, val)]) 
+      cat <- psi[, sum(wt * prob), by = .(c_idx, variable, val)]
+      cat <- setDT(cat)[, .SD[which.max.random(V1)], by = .(c_idx, variable)]
       synth_cat <- dcast(cat, c_idx ~ variable, value.var = 'val')[, c_idx := NULL]
     }