Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 0.11.3 #354

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update to 0.11.3 #354

wants to merge 3 commits into from

Conversation

tlogan2000
Copy link
Collaborator

@tlogan2000 tlogan2000 commented Jul 13, 2023

Overview

Update finch config to most recent release : https://github.com/bird-house/finch/releases/tag/v0.11.3

Changes

Non-breaking changes

  • Adds finch v0.11.1

@tlogan2000 tlogan2000 requested a review from tlvu July 13, 2023 18:46
@github-actions github-actions bot added the feature/WPS Feature or service related to Web Processing Service label Jul 13, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR.
Make sure you have looked at CONTRIBUTING guidelines.

@tlogan2000
Copy link
Collaborator Author

@tlvu I think this is all that's needed to deploy the new finch image?

@Zeitsperre
Copy link
Contributor

@tlogan2000 not sure if it's of interest, but the dockerfile will be cleaned up in my PR. Is it worth waiting?

@tlogan2000
Copy link
Collaborator Author

@tlogan2000 not sure if it's of interest, but the dockerfile will be cleaned up in my PR. Is it worth waiting?

yes no rush

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1822/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : update_finch_version
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-88.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1218/

NOTEBOOK TEST RESULTS
    
[2023-07-13T19:04:21.553Z] ============================= test session starts ==============================
[2023-07-13T19:04:21.553Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2023-07-13T19:04:21.553Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2023-07-13T19:04:21.553Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2023-07-13T19:04:21.553Z] collected 236 items
[2023-07-13T19:04:21.553Z] 
[2023-07-13T19:04:30.514Z] notebooks-auth/test_thredds.ipynb ...........                            [  4%]
[2023-07-13T19:04:35.287Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .FFFFF.        [  7%]
[2023-07-13T19:04:44.978Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 10%]
[2023-07-13T19:04:52.029Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 13%]
[2023-07-13T19:12:28.980Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 18%]
[2023-07-13T19:12:30.898Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 19%]
[2023-07-13T19:12:39.547Z] ...............                                                          [ 25%]
[2023-07-13T19:12:49.204Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 27%]
[2023-07-13T19:12:56.535Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 30%]
[2023-07-13T19:13:12.642Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 32%]
[2023-07-13T19:13:14.028Z] pavics-sdi-master/docs/source/notebooks/jupyter_extensions.ipynb .       [ 33%]
[2023-07-13T19:13:19.430Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 36%]
[2023-07-13T19:13:24.222Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 38%]
[2023-07-13T19:17:35.907Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 44%]
[2023-07-13T19:18:48.012Z] .............                                                            [ 50%]
[2023-07-13T19:18:50.445Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 51%]
[2023-07-13T19:18:52.659Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 55%]
[2023-07-13T19:19:08.173Z] ...F......F......                                                        [ 62%]
[2023-07-13T19:19:17.053Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ..F.F.          [ 64%]
[2023-07-13T19:19:18.444Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 65%]
[2023-07-13T19:19:27.646Z] ..F......                                                                [ 69%]
[2023-07-13T19:19:39.524Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 73%]
[2023-07-13T19:19:49.822Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 76%]
[2023-07-13T19:19:51.215Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 76%]
[2023-07-13T19:19:54.317Z] ......                                                                   [ 79%]
[2023-07-13T19:20:00.890Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2023-07-13T19:20:20.689Z] .............                                                            [ 85%]
[2023-07-13T19:20:30.701Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 85%]
[2023-07-13T19:21:05.419Z] ....s.                                                                   [ 88%]
[2023-07-13T19:21:13.565Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 88%]
[2023-07-13T19:21:28.345Z] ...                                                                      [ 89%]
[2023-07-13T19:21:40.574Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 90%]
[2023-07-13T19:22:03.195Z] ......                                                                   [ 92%]
[2023-07-13T19:22:05.667Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2023-07-13T19:25:10.390Z] notebooks/stress-tests.ipynb .....                                       [100%]
[2023-07-13T19:25:10.390Z] 
[2023-07-13T19:25:10.390Z] =================================== FAILURES ===================================
    
  

@tlvu
Copy link
Collaborator

tlvu commented Jul 14, 2023

@tlvu I think this is all that's needed to deploy the new finch image?

@tlogan2000
Yes, that's all that is needed to update Finch.

However, it seems 2 notebooks are failing in the pipeline

[2023-07-13T19:18:52.659Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 55%]
[2023-07-13T19:19:08.173Z] ...F......F......                                                        [ 62%]
[2023-07-13T19:19:17.053Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ..F.F.          [ 64%]

When there are notebooks failure, we will need to deploy this Finch to a test PAVICS server to investigate.

@tlogan2000 tlogan2000 changed the title update to 0.11.1 update to 0.11.3 Aug 25, 2023
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/1982/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : update_finch_version
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-216.rdext.crim.ca

Infrastructure deployment failed. Instance has not been destroyed. @matprov

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2623/
ResultFAILURE

BIRDHOUSE_DEPLOY_BRANCH : update_finch_version
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-46.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1589/

NOTEBOOK TEST RESULTS
    
[2024-05-01T14:21:25.227Z] ============================= test session starts ==============================
[2024-05-01T14:21:25.227Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2024-05-01T14:21:25.227Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-05-01T14:21:25.227Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2024-05-01T14:21:25.227Z] collected 259 items
[2024-05-01T14:21:25.227Z] 
[2024-05-01T14:21:36.097Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-05-01T14:22:10.853Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-05-01T14:22:15.981Z] notebooks-auth/test_thredds.ipynb ...........                            [ 15%]
[2024-05-01T14:23:04.464Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 17%]
[2024-05-01T14:23:14.020Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 20%]
[2024-05-01T14:23:24.176Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 22%]
[2024-05-01T14:23:35.911Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 25%]
[2024-05-01T14:31:04.795Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 30%]
[2024-05-01T14:31:08.098Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 30%]
[2024-05-01T14:31:16.439Z] ...............                                                          [ 36%]
[2024-05-01T14:31:25.864Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 38%]
[2024-05-01T14:31:32.774Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 40%]
[2024-05-01T14:31:49.902Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 42%]
[2024-05-01T14:31:54.983Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 45%]
[2024-05-01T14:31:59.664Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 47%]
[2024-05-01T14:35:11.204Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 53%]
[2024-05-01T14:36:28.597Z] .............                                                            [ 58%]
[2024-05-01T14:36:30.773Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 59%]
[2024-05-01T14:36:32.982Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 62%]
[2024-05-01T14:36:50.844Z] ...F......F......                                                        [ 69%]
[2024-05-01T14:36:59.172Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ..F...          [ 71%]
[2024-05-01T14:37:09.921Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 76%]
[2024-05-01T14:37:19.951Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 78%]
[2024-05-01T14:37:21.858Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 78%]
[2024-05-01T14:37:25.682Z] ......                                                                   [ 81%]
[2024-05-01T14:37:47.627Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 81%]
[2024-05-01T14:38:15.932Z] .............                                                            [ 86%]
[2024-05-01T14:38:28.160Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 86%]
[2024-05-01T14:39:32.537Z] ....s.                                                                   [ 89%]
[2024-05-01T14:39:40.668Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 89%]
[2024-05-01T14:39:56.196Z] ..                                                                       [ 90%]
[2024-05-01T14:40:11.120Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 90%]
[2024-05-01T14:40:34.488Z] ......                                                                   [ 93%]
[2024-05-01T14:40:37.854Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-05-01T14:43:32.703Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-05-01T14:43:32.703Z] 
[2024-05-01T14:43:32.703Z] =================================== FAILURES ===================================
    
  

Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fixes to the CI notebooks to support the new version.

@mishaschwartz
Copy link
Collaborator

@fmigneault

Needs fixes to the CI notebooks to support the new version.

Ouranosinc/pavics-sdi#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/WPS Feature or service related to Web Processing Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants