Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Issues Fix #282

Merged
merged 25 commits into from
Aug 10, 2023
Merged

Audit Issues Fix #282

merged 25 commits into from
Aug 10, 2023

Conversation

chexware
Copy link
Contributor

@chexware chexware commented Jul 19, 2023

Initial version. Following to be reviewed

  • Mining Pallet: Storage fees for add_mining_origin are charged to the account set as mining origin account, not the origin that called the extrinsic
  • Governance Pallet: Storage fees for fast_track_proposal are currently charged to the proposal creator, not the origin that called the extrinsic
  • Reward Pallet: Storage fees for set_reward_origin are charged to the account parameter, not the origin that called the extrinsic
  • Estate Pallet: Storage fees for issuing undeployed land block are charged to the beneficiary, not the origin that called the extrinsic

@chexware chexware changed the title Post-audit fixes Audit Issues Fix Jul 19, 2023
@justinphamnz justinphamnz merged commit 8c58979 into bit-country:master Aug 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants