Forward port bitcoin-util evalscript and getdeploymentinfo script flags #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was closed, but I think you still want to go forward with bitcoin#28802 ? |
|
Yep. This was only closed because I accidently deleted the branch it was targeted to when trying to bump to 28.0 🥇 ... Will reopen soon once I've rebased |
ajtowns
force-pushed
the
202408-inq28-evalscript
branch
from
b59d258
to
dc9a67a
Compare
Moves FormatScriptFlags logic into GetScriptFlagNames which returns a vector of strings. For completeness, also has GetScriptFlagNames report on any bits that do not match a known script flag.
ajtowns
force-pushed
the
202408-inq28-evalscript
branch
from
dc9a67a
to
6458e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port from #58, incorporating upstream bitcoin#28802