added function bytes to Utf8 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junderw pls go through it and suggest if some changes are required. |
junderw
requested changes
Apr 11, 2024
| @@ -11,6 +11,10 @@ const HEX_CODEPOINTS: (number | undefined)[] = Array(256) | |||
| const ENCODER = new TextEncoder(); | |||
| const DECODER = new TextDecoder("ascii"); | |||
|
|
|||
| export function toUtf8(bytes: Uint8Array): string { | |||
| return DECODER.decode(bytes); | |||
There was a problem hiding this comment.
The TextDecoder is not returning utf8 strings.
Uint8Array.from([ 227, 129, 147, 227, 130, 147, 227, 129, 171, 227, 129, 161, 227, 129, 175 ])
This should equal "こんにちは" but it doesn't. It returns "ã\x81“ã‚“ã\x81«ã\x81¡ã\x81¯"
Can you figure out why?
There was a problem hiding this comment.
okay.. i'll look into it
|
The reason "toUtf8" was giving a different output was |
junderw
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request fixes #3
new function "toUtf8" has been added in both browser.ts and index.ts files. this function efficiently converts a typedArray to Utf8 encoded string.
some new tests have also been added to verify the correctness of the code