fix: fix minion default bucket #37693
Conversation
Signed-off-by: yang.yu <yang.yu@chaitin.com>
yywing
force-pushed
the
a
branch
2 times, most recently
from
717f248
to
2a21692
Compare
Signed-off-by: yang.yu <yang.yu@chaitin.com>
|
How is it going? |
|
We are going to review this logic internally as we want to further investigate the behaviour of the field that you propose to modify with a variable. We will notify you in this PR when there is any news. |
|
still open? |
|
ping |
bitnami/minio/2023/debian-11/rootfs/opt/bitnami/scripts/libminio.sh
Outdated
Show resolved
Hide resolved
| # Start MinIO server in background | ||
| minio_start_bg | ||
| # Ensure MinIO Client is stopped when this script ends. | ||
| trap "minio_stop" EXIT | ||
|
|
||
| # set client env |
There was a problem hiding this comment.
Could you explain the reason for moving this logic after minio starts?
There was a problem hiding this comment.
Because minio will compare all MINIO_* env, it will cause server env not match error when set client env in front.
There was a problem hiding this comment.
This could affect initialisation, and the explanation is not clear to me. Could you give more details?
…io.sh Co-authored-by: Michiel <mdhont79@gmail.com> Signed-off-by: yywing <386542536@qq.com>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
bitnami-bot
added
stale
Description of the change
Wait for all node run create bucket done, then restart all node.
Benefits
Possible drawbacks
Applicable issues
Additional information