Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/*] Create a TESTING.md document #41416

Merged
merged 9 commits into from
Aug 1, 2023
Merged

[bitnami/*] Create a TESTING.md document #41416

merged 9 commits into from
Aug 1, 2023

Conversation

FraPazGal
Copy link
Contributor

Description of the change

This PR adds the testing documentation for our bitnami/containers catalog, detailing how the current strategy works and the steps to create a new test suite.

FraPazGal added 2 commits July 7, 2023 18:07
Add steps for Goss local execution
ea06fc3 
Signed-off-by: FraPazGal <fdepaz@vmware.com>
Finish documentation and add missing info for templates
eb1fe67 
Signed-off-by: FraPazGal <fdepaz@vmware.com>
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jul 19, 2023
Fran de Paz Galán added 3 commits July 19, 2023 17:20
Merge branch 'main' into add-testing-doc
14c6863 
Signed-off-by: Fran de Paz Galán <fdepaz@vmware.com>
Fix linter errors
ce456a3 
Signed-off-by: FraPazGal <fdepaz@vmware.com>
Merge branch 'add-testing-doc' of github.com:bitnami/containers into …
0c0f0e4 
…add-testing-doc
@FraPazGal FraPazGal requested a review from joancafom July 20, 2023 12:16
@FraPazGal FraPazGal assigned FraPazGal and unassigned gongomgra Jul 20, 2023
@FraPazGal FraPazGal removed the request for review from gongomgra July 20, 2023 12:16
joancafom
joancafom reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@joancafom joancafom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have not finished the review yet, but here you have some comments I've noted down until now

.vib/common/goss/templates/check-ca-certs.yaml Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
Fran de Paz added 2 commits July 26, 2023 12:00
Remove GOSS template modifications
2ef593d 
Signed-off-by: Fran de Paz <fdepaz@vmware.com>
Fix typo
7a3142b 
Signed-off-by: Fran de Paz <fdepaz@vmware.com>
joancafom
joancafom reviewed Aug 1, 2023
View reviewed changes
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
TESTING.md Outdated Show resolved Hide resolved
Fran de Paz Galán and others added 2 commits August 1, 2023 17:01
@joancafom
Apply suggestions from code review
b1236b7 
Co-authored-by: Jose Antonio Carmona <jcarmona@vmware.com>
Signed-off-by: Fran de Paz Galán <fdepaz@vmware.com>
Add rest of review suggestions
ac1cdf5 
Signed-off-by: Fran de Paz <fdepaz@vmware.com>
@FraPazGal FraPazGal merged commit 7f94f7e into main Aug 1, 2023
8 checks passed
@FraPazGal FraPazGal deleted the add-testing-doc branch August 1, 2023 15:29
@github-actions github-actions bot added the solved label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joancafom joancafom joancafom approved these changes

Assignees

@FraPazGal FraPazGal

Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FraPazGal @joancafom @gongomgra @bitnami-bot