Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] Add SCRAM support for KRaft #42416

Closed
wants to merge 2 commits into from
Closed

[bitnami/kafka] Add SCRAM support for KRaft #42416

wants to merge 2 commits into from

Conversation

Rablet
Copy link
Contributor

@Rablet Rablet commented Jul 26, 2023

Description of the change

The Kafka container is currently hardcoded to use Zookeeper for SCRAM credential storage. This PR adds support for using KRaft.

It uses kafka-storage.sh to create the configured users during initialisation. This functionality is described here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-900%3A+KRaft+kafka-storage.sh+API+additions+to+support+SCRAM+for+Kafka+Brokers

Benefits

Support for SCRAM using KRaft

Possible drawbacks

Unknown

Applicable issues

#41415

Additional information

This is my first ever PR, please let me know if I've done something wrong 😄

@Rablet
Copy link
Contributor Author

Rablet commented Jul 26, 2023

I should note SASL with the CONTROLLER listener still doesn't work with this. It works with the other listeners and I'm not sure how to get it working for the controller listener.

Signed-off-by: Robin <hi@rablet.dev>
@javsalgar javsalgar added the verify Execute verification workflow for these changes label Jul 26, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Jul 26, 2023
@bitnami-bot bitnami-bot removed the request for review from carrodher July 26, 2023 12:07
Signed-off-by: Robin <hi@rablet.dev>
@migruiz4
Copy link
Member

migruiz4 commented Aug 1, 2023

Hi @Rablet,

Thank you very much for your contribution but I will have to close this PR due to conflicts with the latest release.

We have released a new version of the bitnami/kafka image that includes new features including SCRAM support for Kafka 3.5+

@migruiz4 migruiz4 closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kafka solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants