Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/postgresql] README was not reflecting the start scripts #45066

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

dhxgit
Copy link
Contributor

@dhxgit dhxgit commented Aug 18, 2023

Description of the change

The start scripts use POSTGRESQL_INITDB_WAL_DIR instead of POSTGRESQL_INITDB_WALDIR.

This just fixes the README.md to reflect the code.

Benefits

The README.md will no longer be wrong.

Possible drawbacks

None

Applicable issues

None (Could also file an issue, but this is a really small and obvious fix I believe)

The start scripts use POSTGRESQL_INITDB_WAL_DIR instead of POSTGRESQL_INITDB_WALDIR.

This just fixes the README.md to reflect the code.

Signed-off-by: Dominik Hannen <dhxgit@users.noreply.github.com>
@github-actions github-actions bot added the triage Triage is needed label Aug 18, 2023
@carrodher carrodher added the verify Execute verification workflow for these changes label Aug 18, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Aug 18, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar August 18, 2023 12:51
@Mauraza
Copy link
Contributor

Mauraza commented Aug 21, 2023

Hi @dhxgit,

Could you be so kind as to tell us why this change? Could you add some documentation?

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Sep 6, 2023
@github-actions
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Sep 11, 2023
@dhxgit
Copy link
Contributor Author

dhxgit commented Sep 13, 2023

Hi @dhxgit,

Could you be so kind as to tell us why this change? Could you add some documentation?

hi, as stated this fixes the documentation(readme), which at the moment does not reflect the underlying code.

atm the documentation says to set the env var named: POSTGRESQL_INITDB_WALDIR

This is wrong as the startup script of the container is checking for POSTGRESQL_INITDB_WAL_DIR.

if you would setup the container according to the readme, you would not be able to set the waldir properly.

see startup script in question here:

https://github.com/bitnami/containers/blob/main/bitnami/postgresql/15/debian-11/rootfs/opt/bitnami/scripts/postgresql-env.sh#L215

I stumbled over this because i was wondering why setting the wal_dir did not work, when i tried to set it up according to the readme.

I hope this clarifies the problem.

fixing it in the readme is the most sensible approach, as fixing the code to make the readme correct would be a bigger change, which would break existing configuration.

@github-actions github-actions bot added triage Triage is needed and removed solved labels Sep 13, 2023
@javsalgar javsalgar changed the title README was not reflecting the start scripts [bitnami/postgresql] README was not reflecting the start scripts Sep 14, 2023
@javsalgar javsalgar removed their request for review September 14, 2023 08:14
@javsalgar javsalgar removed their assignment Sep 14, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Sep 14, 2023
@bitnami-bot bitnami-bot removed the request for review from Mauraza September 14, 2023 08:15
@Mauraza Mauraza assigned Mauraza and unassigned migruiz4 Sep 14, 2023
@Mauraza Mauraza requested review from Mauraza and removed request for migruiz4 September 14, 2023 10:23
@Mauraza Mauraza reopened this Sep 14, 2023
@github-actions github-actions bot added triage Triage is needed and removed in-progress labels Sep 14, 2023
Copy link
Contributor

@Mauraza Mauraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dhxgit,

You are right, thanks for the contribution!!
LGTM!

@Mauraza Mauraza merged commit 3b4ffd9 into bitnami:main Sep 14, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postgresql solved stale 15 days without activity triage Triage is needed verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants