-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/kafka] change zookeeper keystore pem location #46901
[bitnami/kafka] change zookeeper keystore pem location #46901
Conversation
Signed-off-by: Babatunde Aromire <babatunde.aromire@cognite.com>
Signed-off-by: Babatunde Aromire <babatunde.aromire@cognite.com>
ea29a97
to
f7ac863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!! The current implementation would also be a problem if the file is mounted as a read-only secret.
I just added a minor suggestion about the style. Could you please check it?
bitnami/kafka/3.2/debian-11/rootfs/opt/bitnami/scripts/libkafka.sh
Outdated
Show resolved
Hide resolved
…a.sh Co-authored-by: Andrés Bono <andresbonojimenez@gmail.com> Signed-off-by: B'Tunde Aromire <babatunde.aromire@cognite.com>
Signed-off-by: Babatunde Aromire <babatunde.aromire@cognite.com>
Actually that might not because I've you can use I've applied and made some changes to the modifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!! The current implementation would also be a problem if the file is mounted as a read-only secret.
I just added a minor suggestion about the style. Could you please check it?Actually that might not because I've you can use
cat
with a readonly mount into container files. In my local docker setup, I mounted all the other certificates asro
save for those of zookeeper because of the modifications.
By "current implementation" I meant the implementation before your PR. I was just highlighting that zookeeper.keystore.pem
could not be mounted as ro
because it needed to be writable. With your PR you are also fixing that. Is that correct?
Please, check my last in-line comment. Thank you!
bitnami/kafka/3.2/debian-11/rootfs/opt/bitnami/scripts/libkafka.sh
Outdated
Show resolved
Hide resolved
Signed-off-by: Babatunde Aromire <babatunde.aromire@cognite.com>
Signed-off-by: Babatunde Aromire <babatunde.aromire@cognite.com>
I hope this is ok? I discovered that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
New container images have been released. Please, pull the latest versions to benefit from your improvement! Thank you. |
Description of the change
I think this necessary because from experience, I find that I keep having to update my local keystore which somehow became more of a burden
Benefits
Eliminate the need to update and change zookeeper.keystore.pem every single time.
Possible drawbacks
None that I can think of.
Applicable issues
Frustrating need to keep updating local zookeeper.keystore.pem evicted.