Update OpenLDAP container readme for environment variables. #49583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenLDAP server itself needs to have a LDAP_Root (aka suffix) and LDAP_ADMIN_DN (aka BindDN) to communicate with the MariaDB container. The equivalent settings are set on MariaDB but not OpenLDAP. This also means that a unfamiliar user may change the MariaDB settings to their own FQDN, but the OpenLDAP server will not reflect this, and lead to frustration of login. Signed-off-by: Bob M <108097756+okbobm@users.noreply.github.com>
Update README.md for OpenLDAP container
|
I'm suggesting adding those variables into the example even if they are the default (perhaps comment as such), as the docker commands will run successfully the first time however the second time with custom domain values (changing the corresponding values in the Maria docker command line), users will struggle to understand that the variables need to be changed on the docker command for the openldap server implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information